Skip to content

Upgrade to the latest version of the ansible-lint pre-commit hook#219

Closed
mcdonnnj wants to merge 1 commit into
developfrom
improvement/upgrade_ansible-lint_hook_version
Closed

Upgrade to the latest version of the ansible-lint pre-commit hook#219
mcdonnnj wants to merge 1 commit into
developfrom
improvement/upgrade_ansible-lint_hook_version

Conversation

@mcdonnnj

Copy link
Copy Markdown
Member

🗣 Description

This pull request updates the ansible-lint pre-commit hook to the latest version.

💭 Motivation and context

Version 25.9.0 is the first version to support Debian Forky as a platform, which is needed to support cisagov/skeleton-ansible-role#236.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj
mcdonnnj requested review from a team and Copilot September 16, 2025 13:54
@mcdonnnj mcdonnnj self-assigned this Sep 16, 2025
@mcdonnnj
mcdonnnj requested a review from jsf9k as a code owner September 16, 2025 13:54
@mcdonnnj mcdonnnj added the dependencies Pull requests that update a dependency file label Sep 16, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the ansible-lint pre-commit hook from version 25.4.0 to 25.9.0 to add support for Debian Forky as a platform, which is required for skeleton-ansible-role compatibility.

  • Updated ansible-lint version in pre-commit configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mcdonnnj mcdonnnj added the hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation label Sep 16, 2025
@jsf9k

jsf9k commented Sep 16, 2025

Copy link
Copy Markdown
Member

@mcdonnnj - Should we create a PR to update all the other pre-commit hooks as well? I was hoping to kick off another full Kraken since I need to update the Ansible roles anyway.

@github-project-automation github-project-automation Bot moved this from In progress to Reviewer approved in Skeleton Maintenance Sep 16, 2025
@mcdonnnj

Copy link
Copy Markdown
Member Author

@mcdonnnj - Should we create a PR to update all the other pre-commit hooks as well. I was hoping to kick off another full Kraken since I need to update the Ansible roles anyway.

Oh yeah if we're doing a full kraken I would rather update the whole configuration. I was just being selective for a partial wave.

@jsf9k

jsf9k commented Sep 16, 2025

Copy link
Copy Markdown
Member

@mcdonnnj - Should we create a PR to update all the other pre-commit hooks as well. I was hoping to kick off another full Kraken since I need to update the Ansible roles anyway.

Oh yeah if we're doing a full kraken I would rather update the whole configuration. I was just being selective for a partial wave.

Let's do the whole configuration, unless you have a good reason not to.

@mcdonnnj

Copy link
Copy Markdown
Member Author

This pull request is superseded by #220.

@mcdonnnj mcdonnnj closed this Sep 16, 2025
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Skeleton Maintenance Sep 16, 2025
@mcdonnnj
mcdonnnj deleted the improvement/upgrade_ansible-lint_hook_version branch September 16, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants